nmaggioni commented on code in PR #16838:
URL: https://github.com/apache/nuttx/pull/16838#discussion_r2285155931
##########
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##########
@@ -569,6 +574,16 @@ int rp2040_common_bringup(void)
}
#endif
+#ifdef CONFIG_SENSORS_TMP112
+ /* Try to register TMP112 device at I2C0 with a common address */
+
+ ret = board_tmp112_initialize(rp2040_i2cbus_initialize(0), 0, 0x48);
Review Comment:
Looking back at the whole process, I would indeed warmly recommend adopting
a modern linter / static checker if possible. Something configurable enough to
catch most of these issues instead of relying on a mix of commit hooks and
homebrewed tools (it's clear to me that some specific checks will still need
them, though, as the codebase is very complex). Maybe `clang-format` could be a
good start? I tried using the `uncrustify` config already present in the repo
but in some cases it made more mess than it cleaned up, for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
