nmaggioni commented on code in PR #16838:
URL: https://github.com/apache/nuttx/pull/16838#discussion_r2285133807
##########
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##########
@@ -569,6 +574,16 @@ int rp2040_common_bringup(void)
}
#endif
+#ifdef CONFIG_SENSORS_TMP112
+ /* Try to register TMP112 device at I2C0 with a common address */
+
+ ret = board_tmp112_initialize(rp2040_i2cbus_initialize(0), 0, 0x48);
Review Comment:
@acassis No worries about being picky, I share your concerns. As you guessed
I followed what was common practice in the neighboring functions, even if it
looked a bit out of place to me as well. I'd suggest moving on as it is mostly
because some time has already been poured in this PR, and maybe a refactor
would look better if it was done globally in one go instead of fixing calls
individually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
