jasonbu commented on code in PR #16344:
URL: https://github.com/apache/nuttx/pull/16344#discussion_r2081333757


##########
arch/arm/src/armv7-a/arm_addrenv.c:
##########
@@ -238,14 +182,27 @@ int up_addrenv_create(size_t textsize, size_t datasize, 
size_t heapsize,
 
   memset(addrenv, 0, sizeof(arch_addrenv_t));
 
+  tablesize = PGTABLE_SIZE * sizeof(uintptr_t);
+  addrenv->l1table = kmm_memalign(tablesize, tablesize);

Review Comment:
   l1 table handle 12bit lookup (1<<12) * sizeof(uintptr_t) , PGTABLE_SIZE is 
already bytes, remove the *sizeof(uintptr_t), but when I try use 
   ```C
   addrenv->l1table = (uintptr_t *)mm_pgalloc(MM_NPAGES(PGTABLE_SIZE));
   ```
   to replace the 
   ```C
   kmm_memalign(PGTABLE_SIZE, PGTABLE_SIZE);
   ```
   still will abort on hello exit. will spend more time to look into what 
happend here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to