pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058891202
########## libs/libc/misc/lib_mutex.c: ########## @@ -389,22 +249,17 @@ int nxmutex_clocklock(FAR mutex_t *mutex, clockid_t clockid, /* Wait until we get the lock or until the timeout expires */ - do + if (abstime) Review Comment: ``` * Description: * This function attempts to lock the mutex referenced by 'mutex'. If the * mutex value is (<=) zero, then the calling task will not return until it * successfully acquires the lock or timed out ``` I think removing the loop violates this promise, either one has to be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org