pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058850944
########## sched/misc/deadlock.c: ########## @@ -100,8 +100,8 @@ static void collect_deadlock(FAR struct tcb_s *tcb, FAR void *arg) pid_t holder; size_t i; - holder = mutex->holder; - if (holder == NXMUTEX_NO_HOLDER) + holder = nxmutex_get_holder(mutex); + if (holder < 0) Review Comment: Looks like legacy but I don't quite understand this special -1 value. Why cant 0 mean no holder ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org