lupyuen commented on code in PR #15996: URL: https://github.com/apache/nuttx/pull/15996#discussion_r1997529510
########## arch/arm64/Kconfig: ########## @@ -37,6 +37,22 @@ config ARCH_CHIP_A64 ---help--- Allwinner A64 SoC +config ARCH_CHIP_A527 Review Comment: Hi @anchao I have refactored the Kconfig: Now we can select `sunxi` for Allwinner 64-bit SoCs: https://github.com/apache/nuttx/blob/ae63d9d00a1d122a25ae27752eba75653717e8a3/arch/arm64/Kconfig#L127-L135 A527 SoC is now inside `sunxi`. In the next PR, I'll add A64 and PinePhone: https://github.com/apache/nuttx/blob/ae63d9d00a1d122a25ae27752eba75653717e8a3/arch/arm64/Kconfig#L145-L163 `ARCH_CHIP_A527` has been renamed to `ARCH_CHIP_SUNXI_A527`. Kconfig looks much cleaner after refactoring. Thanks for the suggestion :-) https://github.com/apache/nuttx/blob/ae63d9d00a1d122a25ae27752eba75653717e8a3/arch/arm64/Kconfig#L357-L360 https://github.com/apache/nuttx/blob/ae63d9d00a1d122a25ae27752eba75653717e8a3/arch/arm64/Kconfig#L503-L505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org