anchao commented on code in PR #15996:
URL: https://github.com/apache/nuttx/pull/15996#discussion_r1997502674
##########
arch/arm64/Kconfig:
##########
@@ -37,6 +37,22 @@ config ARCH_CHIP_A64
---help---
Allwinner A64 SoC
+config ARCH_CHIP_A527
Review Comment:
It seems Espressif's soc has done something similar, and same changes may be
possible in arm64:
```
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 5952b8e086..1253dcc208 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -26,16 +26,15 @@ choice
prompt "ARM64 chip selection"
default ARCH_CHIP_QEMU
-config ARCH_CHIP_A64
- bool "Allwinner A64"
- select ARCH_CORTEX_A53
+config ARCH_CHIP_SUNXI
+ bool "Allwinner sunxi 64-bit SoC Family"
select ARCH_HAVE_ADDRENV
select ARCH_HAVE_RESET
select ARCH_HAVE_IRQTRIGGER
select ARCH_NEED_ADDRENV_MAPPING
select ARM64_HAVE_PSCI
---help---
- Allwinner A64 SoC
+ Allwinner sunxi 64-bit SoC Family
config ARCH_CHIP_RK3399
bool "Rockchip RK3399"
@@ -324,7 +323,7 @@ config ARCH_FAMILY
config ARCH_CHIP
string
- default "a64" if ARCH_CHIP_A64
+ default "a64" if ARCH_CHIP_SUNXI_A64
default "rk3399" if ARCH_CHIP_RK3399
default "zynq-mpsoc" if ARCH_CHIP_ZYNQ_MPSOC
default "qemu" if ARCH_CHIP_QEMU
@@ -372,7 +371,7 @@ config ARM64_DECODEFIQ
config ARM64_GIC_VERSION
int "GIC version"
- default 2 if ARCH_CHIP_A64 || ARCH_CHIP_BCM2711
+ default 2 if ARCH_CHIP_SUNXI_A64 || ARCH_CHIP_BCM2711
default 3
range 2 4
---help---
@@ -463,8 +462,27 @@ config ARM64_PA_BITS
The choice could be: 32, 36, 42, 48
-if ARCH_CHIP_A64
-source "arch/arm64/src/a64/Kconfig"
+if ARCH_CHIP_SUNXI
+
+choice
+ prompt "ARM64 chip selection"
+ default ARCH_CHIP_SUNXI_A64
+
+config ARCH_CHIP_SUNXI_A64
+ bool "Allwinner A64"
+ select ARCH_CORTEX_A53
+ select ARCH_HAVE_ADDRENV
+ select ARCH_HAVE_RESET
+ select ARCH_HAVE_IRQTRIGGER
+ select ARCH_NEED_ADDRENV_MAPPING
+ select ARM64_HAVE_PSCI
+ ---help---
+ Allwinner A64 SoC
+
+endif
+
+if ARCH_CHIP_SUNXI_A64
+source "arch/arm64/src/sunxi/a64/Kconfig"
endif
if ARCH_CHIP_RK3399
```
I don't know if it helps, but this may let developers know that this is
allwinner's soc from the directory and configuration naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
