anchao commented on PR #15862: URL: https://github.com/apache/nuttx/pull/15862#issuecomment-2674717797
> Hi @anchao , > > I agree with these changes, but we have been discussing about code quality and how PRs should be provided (and reviewed). > > In that sense, please adhere to the guidelines to fill the PR's descriptions: the bot provide useful instructions to fill it here: [#15862 (comment)](https://github.com/apache/nuttx/pull/15862#issuecomment-2667321613) > > The most important section is the **Impact**. Please provide how it impacts existing builds and how this impact could be mitigated. Also, provide a summary of why this change is happening (you can link previous discussions). > > In general, act as if you were a beginner on NuttX willing to help review a merge request: the MR must provide all the necessary info to it, starting by clearly pointing out the motivation for the change, and how it impacts the RTOS and a testing section. I think you should understand my original intention of submitting this patch, which is to solve the consistency problem in the current code https://github.com/apache/nuttx/pull/15767. If you don't want to approve it, just leave it pending here. I don't want 90% of my work to be about introducing what I'm doing. Open source for Nuttx is just my interest. If it becomes a burden to me, I'd rather not do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
