tmedicci commented on PR #15862: URL: https://github.com/apache/nuttx/pull/15862#issuecomment-2674344190
Hi @anchao , I agree with these changes, but we have been discussing about code quality and how PRs should be provided (and reviewed). In that sense, please adhere to the guidelines to fill the PR's descriptions: the bot provide useful instructions to fill it here: https://github.com/apache/nuttx/pull/15862#issuecomment-2667321613 The most important section is the **Impact**. Please provide how it impacts existing builds and how this impact could be mitigated. Also, provide a summary of why this change is happening (you can link previous discussions). In general, act as if you were a beginner on NuttX willing to help review a merge request: the MR must provide all the necessary info to it, starting by clearly pointing out the motivation for the change, and how it impacts the RTOS and a testing section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
