cederom commented on PR #15767: URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2649028804
> @tmedicci: @cederom , I think we have enough information to merge this PR: we revert to the point we were (and continue discussing about the changes). I don't see any reason to not revert it temporarily (and let the API behave as it used to). My main concern is that we are calling a "revert" something that is not a revert, but "partial revert with some fixes included".. so we should call it "fix" not "revert" in order to keep words meaningful ;-) Also no runtime logs from at least real world hardware are provided in the description how the fix/revert works. We need this information just to make sure that fix/revert does not break something else :-P We had long discussion on the mailing list and I hope we will first discuss breaking changes on the mailing list, block undiscussed breaking PRs by default, and in best situation avoid breaking changes by creating alternative and compatible solutions instead :-) As everyone seems happy with presented solution in current form you have my go :-) Also I have confirmation from affected end user: >Regarding this pull request:I'm trying to test it quickly on our >STM32F427 based board, I cant pull the jtag probe before monday. > >I have checked out the apache_8 branch of >https://github.com/hujun260/nuttx/tree/apache_8 > >-the tools/process_config.sh file is still broken, I could work around >that by replacing the file with my version > >-the build completes without updating my apps > >-the build completes on my colleague's machine > > -THE BOARD BOOTS to NSH (not our app, but thats probably another config > update we can fix easily) > >So the runtime problem we had is actually caused by these changes. > >Conclusion: I validate this revert, It fixes our build. > > Thank you all. >Sebastien -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
