patacongo commented on a change in pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#discussion_r434568001



##########
File path: libs/libc/stdio/lib_fputs.c
##########
@@ -60,7 +60,7 @@
  ****************************************************************************/
 
 #if defined(CONFIG_ARCH_ROMGETC)
-int fputs(FAR const char *s, FAR FILE *stream)
+int fputs(FAR const IPTR char *s, FAR FILE *stream)

Review comment:
       The safest thing to do would be to make no changes now.  Or, perhaps as 
in your previous change, just add IPTR to the function prototype.  I think this 
is one of those subjects that requires and clear understanding of the effected 
platforms and a plan for exactly how we want them to work.  Let's not merge 
this until we have those things.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to