patacongo edited a comment on pull request #1180: URL: https://github.com/apache/incubator-nuttx/pull/1180#issuecomment-637763581
This function did not need to be decorated with IPTR since it explicitly copied the bytes from ROM. IPTR is a special storage class for Harvard architecture maches that indicates that the pointed to data resides in instruction (ROM) space. In this case, it would instead explicitly copy from instruction space. This function is older than IPTR. If you are going to remove this function, then could you please add IPTR to the string pointer argument? Currrently, the copy from ROM, either explicitly as here or implicitly using IPTR is required for all AVR builds. When IPTR is present for the AVR, it adds the storage class _memx to the string. The AVR compiler will then fetch all data from instruction space. It is a nice clean solution that does not require the explicit call that you are removing. If you add IPTR to the input string pointer, then full functionality should still be present. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
