xiaoxiang781216 commented on a change in pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#discussion_r437881376
##########
File path: libs/libc/stdio/lib_fputs.c
##########
@@ -60,7 +60,7 @@
****************************************************************************/
#if defined(CONFIG_ARCH_ROMGETC)
-int fputs(FAR const char *s, FAR FILE *stream)
+int fputs(FAR const IPTR char *s, FAR FILE *stream)
Review comment:
I don't know that whether __mem become the standard gcc feature. But if
it's true we can create a new patch to remove all up_romgetc stuff later in one
patch. At least, we need make the current code ase consistent with each other:
it's very strange that printf call up_romgetc but scanf don't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
