oscarArismendi commented on code in PR #3182:
URL: https://github.com/apache/iggy/pull/3182#discussion_r3175272460
##########
foreign/node/src/bdd/message.ts:
##########
@@ -34,15 +34,15 @@ When(
async function (
this: TestWorld,
msgCount: number,
- streamId: number,
- topicId: number,
+ _streamId: number,
Review Comment:
I prefixed it to indicate to [TypeScript that it’s an unused/ignored
variable](https://www.typescriptlang.org/tsconfig/#noUnusedParameters). Because
while running the tests and investigating why they were failing, I realized the
server assigns these values at runtime. You can verify this by going to the
main branch and changing the last test in basic_messaging.feature to use a
different streamId, the tests will fail, but in this branch they would pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
