T1B0 commented on code in PR #3182:
URL: https://github.com/apache/iggy/pull/3182#discussion_r3163053452
##########
foreign/node/src/bdd/message.ts:
##########
@@ -34,15 +34,15 @@ When(
async function (
this: TestWorld,
msgCount: number,
- streamId: number,
- topicId: number,
+ _streamId: number,
Review Comment:
even if you use this.stream.id over argument i don't see why prefixing with
"_"
##########
foreign/node/src/bdd/stream.ts:
##########
@@ -23,7 +23,10 @@ import { Given, When, Then } from "@cucumber/cucumber";
import type { TestWorld } from './world.js';
Given('I have no streams in the system', async function (this: TestWorld) {
- assert.deepEqual([], await this.client.stream.list());
+ const streams = await this.client.stream.list();
Review Comment:
i don't understand the point of this change, it used to assert now it delete
? are you fixing the fact that you can't run bdd test twice without restart
server because a fresh state is needed ?
##########
foreign/node/src/wire/message/send-messages.command.ts:
##########
@@ -21,7 +21,7 @@
import { type Id } from '../identifier.utils.js';
import { serializeSendMessages, type CreateMessage } from './message.utils.js';
import type { Partitioning } from './partitioning.utils.js';
-import { deserializeVoidResponse } from '../../client/client.utils.js';
+import {deserializeStatusResponse, deserializeVoidResponse} from
'../../client/client.utils.js';
Review Comment:
clean up deserializeVoidResponse from import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
