oscarArismendi commented on code in PR #3182:
URL: https://github.com/apache/iggy/pull/3182#discussion_r3175262911
##########
foreign/node/src/bdd/stream.ts:
##########
@@ -23,7 +23,10 @@ import { Given, When, Then } from "@cucumber/cucumber";
import type { TestWorld } from './world.js';
Given('I have no streams in the system', async function (this: TestWorld) {
- assert.deepEqual([], await this.client.stream.list());
+ const streams = await this.client.stream.list();
Review Comment:
Yes, my tests were failing because I needed a fresh state. On second
thought, I may have gone overboard by adding the delete step in the Given and
changing its behavior, using an `After` hook might be a better approach. I’ve
updated it in[ my latest
commit](https://github.com/apache/iggy/pull/3182/changes/11990e3dfc27e22a1f62e464e6c0e8830c2fab71#diff-6101ebb91c527c6adc0d2df5c01b26213bccdcb26f277810fbe32472602b31d1R56-R62),
let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
