Tyooughtul commented on code in PR #2656:
URL: https://github.com/apache/iggy/pull/2656#discussion_r3026443536
##########
Cargo.toml:
##########
@@ -285,6 +285,7 @@ trait-variant = "0.1.2"
tungstenite = "0.29.0"
twox-hash = { version = "2.1.2", features = ["xxhash32"] }
ulid = "1.2.1"
+ureq = "2.10"
Review Comment:
> Why do we need yet another HTTP client when reqwest is already there?
I tried reqwest firstly, but it brings in tokio as a hard dependency. The
server crate runs on compio runtime, so that's not compatible. I chose ureq
over reqwest blocking because it's lighter weight and ~zero async runtime
overhead for a simple synchronous fetch that happens infrequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
