Tyooughtul commented on code in PR #2656:
URL: https://github.com/apache/iggy/pull/2656#discussion_r2985872233
##########
core/common/src/types/configuration/http_config/http_client_config_builder.rs:
##########
@@ -45,6 +45,12 @@ impl HttpClientConfigBuilder {
self
}
+ /// Sets the JWT token for A2A authentication.
+ pub fn with_jwt_token(mut self, token: String) -> Self {
Review Comment:
@spetz Thanks for the suggestion! 😊 You're right that jwt is more concise.
I went with jwt_token mainly to:
- Stay consistent with existing *_token patterns in the codebase, e.g.,
access_token, personal_access_token, RevokedAccessToken.
- We have both Iggy-generated access_token and external A2A JWT. The _token
suffix makes it clear this is the external JWT string that gets used as the
access token. Also, with_jwt_token(token) is slightly more explicit for callers
about what to pass in.
That said, I don't feel strongly about it. Happy to change to jwt if you
prefer the shorter form — just let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
