Tyooughtul commented on code in PR #2656:
URL: https://github.com/apache/iggy/pull/2656#discussion_r3026390463
##########
core/sdk/src/clients/consumer.rs:
##########
@@ -569,6 +569,9 @@ impl IggyConsumer {
DiagnosticEvent::Connected => {
trace!("Connected to the server");
joined_consumer_group.store(false, ORDERING);
+ if !is_consumer_group {
Review Comment:
> Where's this change coming from?
It's a bug fix for anonymous standalone consumers. SignedIn only fires with
auth, anonymous clients would hang forever after reconnect since nothing would
set can_poll = true. This mirrors the existing SignedIn logic for standalone
consumers -> line 588-590. 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
