slbotbm commented on PR #3046: URL: https://github.com/apache/iggy/pull/3046#issuecomment-4168625898
@seokjin0414 Thanks for the update! I'll review this by friday/saturday. In the meantime, could you please: 1. rebase this pr and fix conflicts, since #2988 was recently merged 2. Fix the failing CI 3. write unit tests for `Message.new_message` in `tests/messages/unit_tests.cpp`? You could refer to https://github.com/apache/iggy/blob/master/foreign/cpp/tests/identifier/unit_tests.cpp to think about what kind of unit tests to write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
