seokjin0414 commented on PR #3046: URL: https://github.com/apache/iggy/pull/3046#issuecomment-4149962223
@slbotbm Thanks for the review! Addressed all feedback in c8f9adfcb: 1. **CI fix**: clang-format applied, fragile `s.id > 0` assertion removed (75c2a2825) 2. **Unified Message struct**: Merged `IggyMessageToSend`/`IggyMessagePolled` into single `Message` with all header fields. Added `new_message(payload)` factory function exported to C++ 3. **TryFrom**: Defined `TryFrom<ffi::Message> for IggyMessage` and use it in `send_messages` 4. **Explicit from**: Replaced `map(Into::into)` with `map(ffi::Stream::from)` / `map(ffi::Message::from)` 5. **Naming**: Renamed to `polling_strategy_kind`/`polling_strategy_value` — these refer to the polling strategy (offset/timestamp/first/last/next), not partitioning. Partitioning params (`partitioning_kind`/`partitioning_value`) are on `send_messages` separately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
