seokjin0414 commented on PR #3046: URL: https://github.com/apache/iggy/pull/3046#issuecomment-4166618524
Done. Added the overlooked tests: | Your question | Test added | |---|---| | Invalid or non-existent partition ID | `PollMessagesWithInvalidPartitionId` — partition 9999 on topic with 1 partition → throws | | count = 0 | `PollMessagesWithCountZero` — returns success with 0 messages (server returns empty, not error) | | Polling without specifying a partition | `PollMessagesWithoutSpecifyingPartition` — UINT32_MAX maps to None, server defaults to partition 0 | | Timestamp strategy (before/between/after) | `PollMessagesTimestampStrategy` — 2 batches with 100ms gap, verifies >= semantics | | Monotonic offset verification | `PollMessagesMonotonicOffsets` — 20 messages, 4 polls of 5, verifies continuous offsets 0-19 | Still not added: - **Batch size limit / poll request limit** — need to investigate actual server limits first - **Consumer group tests** — pending #2988 - **Property-based testing** — covered with manual cases (null bytes, UTF-8, binary) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
