linliu-code commented on code in PR #13950:
URL: https://github.com/apache/hudi/pull/13950#discussion_r2384160733
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala:
##########
@@ -618,10 +618,20 @@ def testBulkInsertForDropPartitionColumn(): Unit = {
.setPartitionFields(fooTableParams(DataSourceWriteOptions.PARTITIONPATH_FIELD.key))
.setKeyGeneratorClassProp(fooTableParams.getOrElse(DataSourceWriteOptions.KEYGENERATOR_CLASS_NAME.key,
DataSourceWriteOptions.KEYGENERATOR_CLASS_NAME.defaultValue()))
- if(addBootstrapPath) {
- tableMetaClientBuilder
-
.setBootstrapBasePath(fooTableParams(HoodieBootstrapConfig.BASE_PATH.key))
- }
+ if
(fooTableParams.contains(HoodieWriteConfig.WRITE_PAYLOAD_CLASS_NAME.key())) {
+
tableMetaClientBuilder.setPayloadClassName(fooTableParams(HoodieWriteConfig.WRITE_PAYLOAD_CLASS_NAME.key))
+ }
+ if (fooTableParams.contains(HoodieWriteConfig.RECORD_MERGE_MODE.key)) {
Review Comment:
Ok, there were some test failures without this settings. Let me remove it,
and test it out again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
