linliu-code commented on code in PR #13950:
URL: https://github.com/apache/hudi/pull/13950#discussion_r2381634786
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamerTestBase.java:
##########
@@ -649,13 +646,6 @@ static HoodieDeltaStreamer.Config makeConfig(String
basePath, WriteOperationType
cfg.schemaProviderClassName = defaultSchemaProviderClassName;
}
cfg.allowCommitOnNoCheckpointChange = allowCommitOnNoCheckpointChange;
- Triple<RecordMergeMode, String, String> mergeCfgs =
- HoodieTableConfig.inferMergingConfigsForWrites(
- cfg.recordMergeMode, cfg.payloadClassName,
cfg.recordMergeStrategyId, cfg.sourceOrderingFields,
- HoodieTableVersion.current());
- cfg.recordMergeMode = mergeCfgs.getLeft();
- cfg.payloadClassName = mergeCfgs.getMiddle();
Review Comment:
I put it back since I saw it broke some tests. We can keep it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
