linliu-code commented on code in PR #13950:
URL: https://github.com/apache/hudi/pull/13950#discussion_r2380490871
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamerTestBase.java:
##########
@@ -649,13 +646,6 @@ static HoodieDeltaStreamer.Config makeConfig(String
basePath, WriteOperationType
cfg.schemaProviderClassName = defaultSchemaProviderClassName;
}
cfg.allowCommitOnNoCheckpointChange = allowCommitOnNoCheckpointChange;
- Triple<RecordMergeMode, String, String> mergeCfgs =
- HoodieTableConfig.inferMergingConfigsForWrites(
- cfg.recordMergeMode, cfg.payloadClassName,
cfg.recordMergeStrategyId, cfg.sourceOrderingFields,
- HoodieTableVersion.current());
- cfg.recordMergeMode = mergeCfgs.getLeft();
- cfg.payloadClassName = mergeCfgs.getMiddle();
Review Comment:
From my observation from another PR: many DeltaStreamer test uses the
cfg.configs to set the merge behavior; otherwise, the default merge mode is
commit time based, since the default payload class is
`OverwriteWithLatestPayload`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
