nsivabalan commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2322996095
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -638,7 +637,7 @@ public static <R> HoodieData<HoodieRecord<R>>
tagGlobalLocationBackToRecords(
}
});
return shouldUpdatePartitionPath
- ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table)
+ ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table, readerContext, writerSchema)
Review Comment:
for your comment Tim `without the merge, we don't know whether to delete the
record key from the index or to skip the delete because it has a lower ordering
value`, only applies to MOR table. for COW, at the end of merge handle, it
should emit right values for whether a record is deleted or not.
For MOR, I agree we don't have much option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
