rahil-c commented on code in PR #13687:
URL: https://github.com/apache/hudi/pull/13687#discussion_r2261905104
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1359,6 +1359,10 @@ public HoodieTableVersion getWriteVersion() {
return
HoodieTableVersion.fromVersionCode(getIntOrDefault(WRITE_TABLE_VERSION));
}
+ public void setWriteVersion(HoodieTableVersion version) {
+ setValue(WRITE_TABLE_VERSION, String.valueOf(version.versionCode()));
+ }
Review Comment:
i see this pattern in other areas of `HoodieWriteConfig`.
https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java#L1333,
hence why I opted for it.
Unless your suggestion is you want to construct a whole new writeConfig
using builder pattern just for this property? If so I guess the main question
is this would not change the writeConfig thats passed down to this method which
I think is not ideal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
