yihua commented on code in PR #13687:
URL: https://github.com/apache/hudi/pull/13687#discussion_r2261946860
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1359,6 +1359,10 @@ public HoodieTableVersion getWriteVersion() {
return
HoodieTableVersion.fromVersionCode(getIntOrDefault(WRITE_TABLE_VERSION));
}
+ public void setWriteVersion(HoodieTableVersion version) {
+ setValue(WRITE_TABLE_VERSION, String.valueOf(version.versionCode()));
+ }
Review Comment:
Ideally we should keep the write config immutable but there do exist setters
for schema. Could you spend half hour and check how hard it is to build a new
write config with a new write table version (by changing the logic in callers)?
If it's hard then it's fine to keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
