yihua commented on code in PR #13687:
URL: https://github.com/apache/hudi/pull/13687#discussion_r2261608690
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -95,6 +95,16 @@ public static boolean needsUpgrade(HoodieTableMetaClient
metaClient, HoodieWrite
throw new HoodieUpgradeDowngradeException(
String.format("Please upgrade table from version %s to %s before
upgrading to version %s.", fromTableVersion,
HoodieTableVersion.SIX.versionCode(), toWriteVersion));
}
+ // for table versions greater than or equal to six, if we are attempting
to do an upgrade and auto-upgrade is disabled
+ if (fromTableVersion.greaterThanOrEquals(HoodieTableVersion.SIX) &&
fromTableVersion.versionCode() < config.getWriteVersion().versionCode() &&
!config.autoUpgrade()) {
Review Comment:
Should we restructure this method to make it readable:
```
step 1: if it is downgrade, return false;
step 2: if `fromTableVersion` is lower than 6, throw exception to let user
know that the table needs to be upgraded to table version 6 using 0.14.0 and
above releases first
step 3: check autoUpgrade and write table version, etc.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
