vinothchandar commented on code in PR #13216:
URL: https://github.com/apache/hudi/pull/13216#discussion_r2178784706
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java:
##########
@@ -524,12 +556,14 @@ protected <T> void transitionStateToComplete(boolean
shouldLock, HoodieInstant f
throw new HoodieIOException(
"Could not rename " + fromInstantPath + " to " + toInstantPath);
}
+ return instantWithCompletionTime;
} else {
// Ensures old state exists in timeline
ValidationUtils.checkArgument(
metaClient.getStorage().exists(getInstantFileNamePath(fromInstantFileName)),
"File " + getInstantFileNamePath(fromInstantFileName) + " does not
exist!");
- createCompleteFileInMetaPath(shouldLock, toInstant, metadata);
+ String completionTime =
HoodieInstantTimeGenerator.formatDateBasedOnTimeZone(new
Date(createCompleteFileInMetaPath(shouldLock, toInstant, metadata)));
Review Comment:
I think this is fine. keeping this open.. and tracking.
Will get @the-other-tim-brown 's eyes on this next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
