vinothchandar commented on code in PR #13216:
URL: https://github.com/apache/hudi/pull/13216#discussion_r2178723240
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -284,7 +284,10 @@ protected void commit(HoodieTable table, String
commitActionType, String instant
}
// update Metadata table
writeTableMetadata(table, instantTime, metadata);
- activeTimeline.saveAsComplete(false,
table.getMetaClient().createNewInstant(HoodieInstant.State.INFLIGHT,
commitActionType, instantTime), Option.of(metadata));
+ activeTimeline.saveAsComplete(false,
+ table.getMetaClient().createNewInstant(HoodieInstant.State.INFLIGHT,
commitActionType, instantTime), Option.of(metadata),
+ completedInstant ->
table.getMetaClient().getTableFormat().commit(metadata, completedInstant,
getEngineContext(), table.getMetaClient(), table.getViewManager())
Review Comment:
I get why you need this now.. Basically, the completion call is different
based on which action calls saveAsComplete..
@danny0405 the Timeline is different when another table format is plugged
in. For native, it just does what we do today. and the
`getTableFormat().commit()` is a no-op. default method in `HoodieTableFormat`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
