vinothchandar commented on code in PR #13216:
URL: https://github.com/apache/hudi/pull/13216#discussion_r2178732003
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/CopyOnWriteRollbackActionExecutor.java:
##########
@@ -67,11 +68,23 @@ protected List<HoodieRollbackStat>
executeRollback(HoodieRollbackPlan hoodieRoll
if (instantToRollback.isCompleted()) {
LOG.info("Unpublishing instant " + instantToRollback);
+ table.getMetaClient().getTableFormat().rollback(instantToRollback,
table.getContext(), table.getMetaClient(), table.getViewManager());
+ // Revert the completed instant to inflight in native format.
resolvedInstant = activeTimeline.revertToInflight(instantToRollback);
// reload meta-client to reflect latest timeline status
table.getMetaClient().reloadActiveTimeline();
}
+ // If instant is inflight but marked as completed in native format, delete
the completed instant from storage.
Review Comment:
When committing -> we commit to native timeline first (A), then plugged-in
tableformat (B)
instantToRollback.isInflight() can be true, if A happened, but we failed
before B. This is fixing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
