nsivabalan commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2153457033
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -189,21 +188,12 @@ private void updateStatsForFailure() {
totalErrorRecords++;
}
- public WriteStatus removeMetadataIndexStatsAndErrorRecordsTracking() {
- removeMetadataStats();
- dropGranularErrorRecordsTracking();
- return this;
- }
-
public WriteStatus removeMetadataStats() {
- this.writtenRecordDelegates.clear();
+ this.indexStats.clear();
+ this.indexStats = null;
return this;
}
- public void dropGranularErrorRecordsTracking() {
- failedRecords.clear();
- }
Review Comment:
this was a clean up which we should have done in previous patch only.
initially we were trying to collect a Slim version of the WriteStatus in
driver in SparkRDDWriteClient.commit method.
later we realized that, we just need HoodieWriteStat and hence these
additional methods are not required only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
