the-other-tim-brown commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2152300775
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -315,16 +319,17 @@ protected void writeInsertRecord(HoodieRecord<T>
newRecord) throws IOException {
protected void writeInsertRecord(HoodieRecord<T> newRecord, Schema schema,
Properties prop)
throws IOException {
- if (writeRecord(newRecord, Option.of(newRecord), schema, prop,
HoodieOperation.isDelete(newRecord.getOperation()))) {
+ if (writeRecord(newRecord, Option.empty(), Option.of(newRecord), schema,
prop, HoodieOperation.isDelete(newRecord.getOperation()))) {
insertRecordsWritten++;
}
}
protected boolean writeRecord(HoodieRecord<T> newRecord,
Option<HoodieRecord> combineRecord, Schema schema, Properties prop) throws
IOException {
- return writeRecord(newRecord, combineRecord, schema, prop, false);
+ return writeRecord(newRecord, Option.empty(), combineRecord, schema, prop,
false);
}
- private boolean writeRecord(HoodieRecord<T> newRecord, Option<HoodieRecord>
combineRecord, Schema schema, Properties prop, boolean isDelete) throws
IOException {
+ private boolean writeRecord(HoodieRecord<T> newRecord,
Option<HoodieRecord<T>> oldRecordOpt, Option<HoodieRecord> combineRecord,
Schema schema, Properties prop,
Review Comment:
Can you add some javadoc or comment explaining the difference between all
the args? Specifically, what is a combineRecord here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
