lokeshj1703 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2154664008
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -452,6 +461,58 @@ protected HoodieRecord<T> updateFileName(HoodieRecord<T>
record, Schema schema,
return record.prependMetaFields(schema, targetSchema, metadataValues,
prop);
}
+ private void trackMetadataIndexStats(Option<HoodieKey> hoodieKeyOpt,
Option<HoodieRecord> combinedRecordOpt, Option<HoodieRecord<T>> oldRecordOpt,
boolean isDelete) {
Review Comment:
I have made the option Nullable. We have fallback logic incase the key is
null.
```
Option<HoodieKey> hoodieKeyOpt = Option.ofNullable(newRecord.getKey());
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -226,6 +231,13 @@ private Option<FileSlice>
populateWriteStatAndFetchFileSlice(HoodieRecord record
return fileSlice;
}
+ private Option<FileSlice> getFileSlice() {
+ Option<FileSlice> fileSlice;
+ TableFileSystemView.SliceView rtView = hoodieTable.getSliceView();
+ fileSlice = rtView.getLatestFileSlice(partitionPath, fileId);
+ return fileSlice;
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
