nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2101602554
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieFileSystemViews.java:
##########
@@ -251,21 +268,36 @@ private void assertFileSliceListEquality(List<FileSlice>
fileSlices1, List<FileS
});
fileNameToFileSliceMap1.entrySet().forEach((kv) -> {
assertTrue(fileNameToFileSliceMap2.containsKey(kv.getKey()));
- assertFileSliceEquality(kv.getValue(),
fileNameToFileSliceMap2.get(kv.getKey()));
+ assertFileSliceEquality(kv.getValue(),
fileNameToFileSliceMap2.get(kv.getKey()), commitMetadataOpt);
});
}
- private void assertFileSliceEquality(FileSlice fileSlice1, FileSlice
fileSlice2) {
+ private void assertFileSliceEquality(FileSlice fileSlice1, FileSlice
fileSlice2, Option<HoodieCommitMetadata> commitMetadataOpt) {
assertEquals(fileSlice1.getBaseFile().isPresent(),
fileSlice2.getBaseFile().isPresent());
if (fileSlice1.getBaseFile().isPresent()) {
assertBaseFileEquality(fileSlice1.getBaseFile().get(),
fileSlice2.getBaseFile().get());
}
List<HoodieLogFile> logFiles1 =
fileSlice1.getLogFiles().collect(Collectors.toList());
List<HoodieLogFile> logFiles2 =
fileSlice2.getLogFiles().collect(Collectors.toList());
- assertEquals(logFiles1.size(), logFiles2.size());
+ if (logFiles1.size() != logFiles2.size()) {
+ if (!commitMetadataOpt.isPresent()) {
+ throw new HoodieException("Log files out of sync. ");
+ } else {
+ // for table version 6, since we deleted the latest completed delta
commit from timeline. baseline FSV might report the log file that's part of
failed commit.
Review Comment:
nope. just a test assertion fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
