nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2101464083
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -179,18 +181,20 @@ public void testListBasedRollbackStrategy() throws
Exception {
List<HoodieRecord> records =
dataGen.generateInsertsContainsAllPartitions(newCommitTime, 3);
JavaRDD<HoodieRecord> writeRecords = jsc.parallelize(records, 1);
JavaRDD<WriteStatus> statuses = client.upsert(writeRecords, newCommitTime);
- Assertions.assertNoWriteErrors(statuses.collect());
+ statuses = jsc.parallelize(statuses.collect(), 1);
+ client.commit(newCommitTime, statuses, Option.empty(), COMMIT_ACTION,
Collections.emptyMap(), Option.empty());
+ assertNoWriteErrors(statuses.collect());
Review Comment:
nope. we already do a collect at L184 and reconstruct the RDD<WriteStatus>
based on a list of WriteStatus.
thats what I have tried to follow whereever I have fixed.
This will ensure we don't trigger the write handles more than once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
