danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2101932015
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -369,6 +375,17 @@ protected void completeCompaction(HoodieCommitMetadata
metadata, HoodieTable tab
LOG.info("Compacted successfully on commit {}", compactionCommitTime);
}
+ public void commitLogCompaction(String compactionInstantTime,
HoodieWriteMetadata<O> writeMetadata, Option<HoodieTable> tableOpt) {
+ // dereferencing the write dag for log compaction for the first time.
+ List<HoodieWriteStat> writeStats =
triggerWritesAndFetchWriteStats(writeMetadata);
+ // fetch HoodieCommitMetadata and update HoodieWriteStat
+ CommonClientUtils.stitchCompactionHoodieWriteStats(writeMetadata,
writeStats);
+ metrics.emitCompactionCompleted();
+ LOG.info("Log Compaction completed. Instant time: {}.",
compactionInstantTime);
Review Comment:
The log happens before the completion, maybe just remove the verbose log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
