rahil-c commented on code in PR #5786:
URL: https://github.com/apache/hudi/pull/5786#discussion_r917452508
##########
hudi-spark-datasource/hudi-spark3/pom.xml:
##########
@@ -262,7 +261,7 @@
<dependency>
<groupId>org.apache.hudi</groupId>
- <artifactId>hudi-spark3-common</artifactId>
+ <artifactId>${hudi.spark.common.module}</artifactId>
Review Comment:
If my understanding is correct I believe the above line is fine. The reason
being that the default profile for this pr is `spark3` which has in the root pom
```
<id>spark3</id>
<properties>
<spark3.version>3.2.1</spark3.version>
<spark.version>${spark3.version}</spark.version>
<sparkbundle.version>3</sparkbundle.version>
<scala.version>${scala12.version}</scala.version>
<scala.binary.version>2.12</scala.binary.version>
<hudi.spark.module>hudi-spark3</hudi.spark.module>
<hudi.spark.common.module>hudi-spark3-common</hudi.spark.common.module>
```
so the `hudi.spark.common.module`will be overriden to use the correct spark3
common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
