[GitHub] [hudi] rahil-c commented on a diff in pull request #5786: [HUDI-2955] Support Hadoop 3.x Hive 3.x and Spark 3.2.x default (rebase)

Sun, 10 Jul 2022 14:52:29 -0700 


rahil-c commented on code in PR #5786:
URL: https://github.com/apache/hudi/pull/5786#discussion_r917451106


##########
pom.xml:
##########
@@ -380,17 +391,24 @@
           <artifactId>maven-jar-plugin</artifactId>
           <version>${maven-jar-plugin.version}</version>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-dependency-plugin</artifactId>
+          <version>${maven-dependency-plugin.version}</version>
+        </plugin>
         <plugin>
           <groupId>net.alchim31.maven</groupId>
           <artifactId>scala-maven-plugin</artifactId>
           <version>${scala-maven-plugin.version}</version>
           <configuration>
+            <recompileMode>all</recompileMode>

Review Comment:
   This change was made by @alexeykudinkin, and from the commit message dont 
have much context as to why it was made. Im assuming it was maybe for some 
testing purposes, for now will remove and see if any issues. 
   
   ```
           <parameter>
             <name>recompileMode</name>
             <type>java.lang.String</type>
             <required>false</required>
             <editable>true</editable>
             <description>Recompile mode to use when sources were previously 
compiled and there is at least one change:
   &quot;modified-only&quot; =&gt; only modified sources are recompiled (pre 
2.13 behavior), &quot;all&quot; =&gt; all sources are recompiled,
   &quot;incremental&quot; =&gt; incrementally recompile modified sources and 
other affected sources.</description>
           </parameter>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to