rahil-c commented on code in PR #5786:
URL: https://github.com/apache/hudi/pull/5786#discussion_r902164267
##########
pom.xml:
##########
@@ -1669,15 +1762,17 @@
<fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}
</fasterxml.jackson.dataformat.yaml.version>
<skip.hudi-spark2.unit.tests>true</skip.hudi-spark2.unit.tests>
- <skipITs>true</skipITs>
+ <skipITs>false</skipITs>
</properties>
<modules>
<module>hudi-spark-datasource/hudi-spark3</module>
<module>hudi-spark-datasource/hudi-spark3-common</module>
</modules>
<activation>
+ <activeByDefault>true</activeByDefault>
<property>
<name>spark3</name>
+ <value>!disabled</value>
Review Comment:
this will cause issue with spark2, since it will add spark3 modules to all
profiles. Have discussed with @yihua for now that we need to explicity pass the
profiles `-Pspark3,scala-2.12` when building
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
