lasdf1234 commented on PR #14055:
URL: https://github.com/apache/gravitino/pull/14055#issuecomment-6312597371
Thanks @roryqi — addressed as follows:
1. **Shared resolution with sources**
- `EffectiveTagResolver.resolveWithSources()` returns `ResolvedTag[]`
(tag + contributing metadata object).
- `ObjectPolicyResolver.resolveMatches()` returns `Match[]` (policy +
sources). A policy that matches via multiple tags keeps those sources.
- `ResolvedTag` / `Match` are nested on the existing resolvers (no new
top-level types).
- `resolve()` / PolicyManager list shape is unchanged.
2. **TMS nearest / conflict only**
`NearestMaintenancePolicyResolver` no longer reimplements selector or
effective-tag matching. It only applies nearest-level and same-level conflict
rules on `resolveMatches()` results.
3. **Table tag-value override**
Covered in `TestObjectPolicyResolver` / `TestEffectiveTagResolver`: table
`data_domain=risk` overriding catalog `finance` does not select a catalog
`TAG_VALUE(finance)` policy.
Please take another look when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
