lasdf1234 commented on PR #13801: URL: https://github.com/apache/gravitino/pull/13801#issuecomment-6168924156
Thanks for the additional review notes — status: 1. **Blocking `withExecutionFields`** — done in recent pushes: immutable `PolicyExecutionSpec` + `ExecutablePolicyContent.executionSpec()`, construction-time only; option values omitted from `toString` / DTO `@ToString`; DTO option maps return unmodifiable copies + `ExecutionPeersDTO` Javadoc. 2. **Design doc vs wire contract** — updated `design-docs/table-maintenance-service-design.md` to flat peers (`commitTrigger` / `timeTrigger` / `minIntervalMs` / `jobOptions` / …), not `content.schedule.*`. Cron examples note that syntax is owned by the TMS / db-scheduler registration path. 3. **“At least one trigger”** — **removed** from the design. Triggers are optional: a policy may set `commitTrigger`, `timeTrigger`, both, or neither. We do not want create/alter to require a trigger; no-trigger policies simply are not enrolled in automated expand/commit until a trigger is added. 4. **Credential-shaped option-key rejection** — still the **design intent** (secrets must not live in policy content; create/alter should reject credential-shaped keys in option bags). **Not implemented in this PR**; that enforcement lands in a follow-up on the server create/alter boundary. Auth stays cluster-static in `gravitino.conf` in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
