lasdf1234 commented on PR #13801: URL: https://github.com/apache/gravitino/pull/13801#issuecomment-6164833209
Thanks for the follow-up review — addressed in the latest push: 1. **BuiltInType registry** — `MaintenancePolicyDefinitions` keyed by `Policy.BuiltInType`; removed the parallel `forBuiltInType` switch. 2. **Peers off `PolicyContent`** — moved to `AbstractExecutablePolicyContent`; only the four Iceberg maintenance contents carry them. 3. **Validation layering** — universal `PolicyContent.validate()` vs executable-peer checks on the abstract type; orphan still rejects `commitTrigger`. Cron runtime / sensitive keys / fuller type contracts → follow-ups. 4. **Terminology** — design-docs §5.0 + registry Javadoc: `BuiltInType` = policy/activity identity; `policy-expand` / `cron-job` / `commit-job` = scheduler task kinds. Also wired Iceberg DTO / `DTOConverters` peer round-trip so REST alter does not drop peers. Happy to iterate if anything still looks off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
