nevzheng commented on code in PR #13057:
URL: https://github.com/apache/gravitino/pull/13057#discussion_r4010084149
##########
docs/iceberg-rest-service.md:
##########
@@ -123,6 +123,7 @@ Do not add them to the standalone server configuration.
| `gravitino.iceberg-rest.idleTimeout` | The timeout in ms of idle
connections.
| `30000`
| No |
| `gravitino.iceberg-rest.requestHeaderSize` | The maximum size of an
HTTP request.
| `131072`
| No |
| `gravitino.iceberg-rest.responseHeaderSize` | The maximum size of an
HTTP response.
| `131072`
| No |
+| `gravitino.iceberg-rest.includeErrorStackTrace` | Whether error responses
include server-side stack traces. Set this to `false` in new deployments
because responses can expose internal implementation details. | `true`
| No |
Review Comment:
Fixed in
https://github.com/apache/gravitino/pull/13057/commits/30c3476185392729b7b83421d7862cdd1ebbd556.
The standalone Iceberg REST template now includes
`gravitino.iceberg-rest.includeErrorStackTrace=true`, documents the
compatibility default, and recommends disabling it for new deployments.
Verified in the generated standalone distribution.
##########
docs/lance-rest-service.md:
##########
@@ -182,6 +183,7 @@ Configure the service by editing
`{GRAVITINO_HOME}/conf/gravitino-lance-rest-ser
| `gravitino.lance-rest.gravitino-metalake` | Gravitino metalake name |
(none) | Yes |
| `gravitino.lance-rest.httpPort` | Service port number |
9101 | No |
| `gravitino.lance-rest.host` | Service hostname |
0.0.0.0 | No |
+| `gravitino.lance-rest.includeErrorStackTrace` | Whether error responses
include stack traces | true | No |
Review Comment:
Fixed in
https://github.com/apache/gravitino/pull/13057/commits/30c3476185392729b7b83421d7862cdd1ebbd556.
The standalone Lance REST template now includes
`gravitino.lance-rest.includeErrorStackTrace=true`, documents the compatibility
default, and recommends disabling it for new deployments. Verified in the
generated standalone distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
