nevzheng commented on code in PR #13057:
URL: https://github.com/apache/gravitino/pull/13057#discussion_r3998084291
##########
server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java:
##########
@@ -542,6 +542,6 @@ public void addSystemFilters(String pathSpec) {
* custom authentication filter (e.g., one that returns Iceberg-spec JSON
error responses).
*/
protected Filter createAuthenticationFilter() {
Review Comment:
Fixed in
https://github.com/apache/gravitino/pull/13057/commits/28f1d8b67da91cf3d341a6f02433aa5240d1edb3.
`createAuthenticationFilter` now takes `includeErrorStackTrace`, with a
documented contract that implementations must not include stack traces when it
is `false`, so every override sees the setting. The Iceberg and Lance filters
honor it because their error bodies never carry a stack, which was previously
untested: `TestIcebergAuthenticationFilter` and `TestLanceAuthenticationFilter`
now assert that. Enforcing this structurally for future REST modules (one
error-exposure policy shared by filters and mappers) fits the follow-up in
#13107.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
