nevzheng commented on code in PR #13057:
URL: https://github.com/apache/gravitino/pull/13057#discussion_r3997990356
##########
server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java:
##########
@@ -116,7 +116,7 @@ public synchronized void initialize(
// Set error handler for Jetty Server
ErrorHandler errorHandler = new ErrorHandler();
- errorHandler.setShowStacks(true);
+ errorHandler.setShowStacks(serverConfig.isIncludeErrorStackTrace());
Review Comment:
Fixed in
https://github.com/apache/gravitino/pull/13057/commits/da9f15a9fd1a1f5c947d00d57c0acc5122a5acca.
`TestJettyServer` now starts the server with a servlet that throws and checks
Jetty's error page in both directions: a stack frame is present by default and
absent with `includeErrorStackTrace=false`, so an inverted or dropped
`setShowStacks` call fails the tests. Covered by
`testErrorPageIncludesStackTraceByDefault` and
`testErrorPageOmitsStackTraceWhenDisabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
