shaoyu-li commented on PR #13058: URL: https://github.com/apache/gravitino/pull/13058#issuecomment-5628597223
Thanks — careful review, and it found two real bugs. Taking most of it. Two things I'd like to argue rather than change, and one of your points turned out sharper than it first looked (the external one). Details in the threads. Also flagging a bug you didn't see, which this revision fixes: when a format serves a create from a table that already exists (Lance `EXIST_OK`, which a client retrying a create hits routinely), the location provisioned for that call is silently leaked. That needs a separate callback from the drop one, since the table is alive — adding `releaseUnusedLocation`, defaulting to a no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
