FANNG1 commented on code in PR #7877:
URL: https://github.com/apache/gravitino/pull/7877#discussion_r2256623666
##########
build.gradle.kts:
##########
@@ -64,21 +62,12 @@ plugins {
alias(libs.plugins.errorprone)
}
-if (extra["jdkVersion"] !in listOf("8", "11", "17")) {
- throw GradleException(
- "The Gravitino Gradle toolchain currently does not support building with "
+
- "Java version ${extra["jdkVersion"]}. Please use JDK versions 8, 11 or
17."
- )
-}
-
val scalaVersion: String = project.properties["scalaVersion"] as? String ?:
extra["defaultScalaVersion"].toString()
if (scalaVersion !in listOf("2.12", "2.13")) {
throw GradleException("Scala version $scalaVersion is not supported.")
}
-project.extra["extraJvmArgs"] = if (extra["jdkVersion"] in listOf("8", "11")) {
- listOf()
-} else {
+project.extra["extraJvmArgs"] =
Review Comment:
In `clientCompatibleWithJDK8 ` mode, the client modules should not use the
following JDK17 vm options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
