diqiu50 commented on code in PR #7877:
URL: https://github.com/apache/gravitino/pull/7877#discussion_r2246694614
##########
build.gradle.kts:
##########
@@ -284,10 +346,12 @@ subprojects {
vendor.set(JvmVendorSpec.AMAZON)
}
languageVersion.set(JavaLanguageVersion.of(17))
- } else {
-
languageVersion.set(JavaLanguageVersion.of(extra["jdkVersion"].toString().toInt()))
+ } else if (CompatibleWithJDK8(project)) {
+ languageVersion.set(JavaLanguageVersion.of(17))
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
Review Comment:
Without -Drelease8, all modules are built (including tests). When -Drelease8
is added, only client-related modules are built with JDK 8 compatibility, and
tests are skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
